feat(android): allow for photo and video capturing and filter for media type for file uploads (onShowFileChooser)
#52
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… videos taking them with the camera, or any other files
…e photo or record video
…the file chooser without camera options References: https://outsystemsrd.atlassian.net/browse/RMET-4466
…give all the options References: https://outsystemsrd.atlassian.net/browse/RMET-4466
…so we need to check if either photo or video was taken References: https://outsystemsrd.atlassian.net/browse/RMET-4466
🎉 Snyk checks have passed. No issues have been found so far.✅ security/snyk check is complete. No issues have been found. (View Details) ✅ license/snyk check is complete. No issues have been found. (View Details) ✅ code/snyk check is complete. No issues have been found. (View Details) |
…allery' into feat/RMET-4466/webview-take-photo-video-gallery
alexgerardojacinto
requested review from
ItsChaceD,
OS-pedrogustavobilro,
OS-ruimoreiramendes and
andredestro
...ain/java/com.outsystems.plugins.inappbrowser/osinappbrowserlib/views/OSIABWebViewActivity.kt
Outdated
Show resolved
Hide resolved
...ain/java/com.outsystems.plugins.inappbrowser/osinappbrowserlib/views/OSIABWebViewActivity.kt
Outdated
Show resolved
Hide resolved
...ain/java/com.outsystems.plugins.inappbrowser/osinappbrowserlib/views/OSIABWebViewActivity.kt
Outdated
Show resolved
Hide resolved
...ain/java/com.outsystems.plugins.inappbrowser/osinappbrowserlib/views/OSIABWebViewActivity.kt
Show resolved
Hide resolved
...ain/java/com.outsystems.plugins.inappbrowser/osinappbrowserlib/views/OSIABWebViewActivity.kt
Outdated
Show resolved
Hide resolved
...ain/java/com.outsystems.plugins.inappbrowser/osinappbrowserlib/views/OSIABWebViewActivity.kt
Show resolved
Hide resolved
...ain/java/com.outsystems.plugins.inappbrowser/osinappbrowserlib/views/OSIABWebViewActivity.kt
Outdated
Show resolved
Hide resolved
...ain/java/com.outsystems.plugins.inappbrowser/osinappbrowserlib/views/OSIABWebViewActivity.kt
Show resolved
Hide resolved
OS-ruimoreiramendes
approved these changes
Sep 8, 2025
OS-pedrogustavobilro
approved these changes
Sep 8, 2025
alexgerardojacinto
added a commit
to ionic-team/capacitor-os-inappbrowser
that referenced
this pull request
Sep 8, 2025
Context: This brings the fix from: OutSystems/OSInAppBrowserLib-Android#52
This was referenced Sep 8, 2025
alexgerardojacinto
added a commit
to ionic-team/capacitor-os-inappbrowser
that referenced
this pull request
Sep 8, 2025
Context: This brings the fix from: OutSystems/OSInAppBrowserLib-Android#52
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
onShowFileChooser, which is responsible for handling requests for the file chooser from the web page open in the WebView, typically for upload scenarios.Context
References: https://outsystemsrd.atlassian.net/browse/RMET-4466
Type of changes
Platforms affected
Tests
Testing this with an app called RMET-4462 TestMob that is available on our O11 environment. It basically opens another OutSystems Reactive Web app (RMET-4462 TestReactive) using our InAppBrowser plugin's
OpenInWebViewfeature.Once you open the web view, you'll see the Upload Widget being used in multiple ways.
Refer to the screen recordings below to see how you can test.
MABS 11.1 build available here
MABS 10 build available here
You can also use the following APK to test:
app-debug.apk.zip
Screenshots (if appropriate)
Uploading on Android
screen-20250905-175750-1757105826866.mp4
Uploading on iOS (for comparison)
ScreenRecording_09-05-2025.17-58-00_1.MP4
Checklist